Skip to content

Update RPC usage charts to handle string values and improve visualization #6766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

Update RPC usage charts to handle string values and improve visualization #6766

merged 1 commit into from
Apr 18, 2025

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 18, 2025 •
edited by pr-codex bot
Loading

Update RPC Usage Dashboard with Enhanced Visualization

This PR updates the RPC usage dashboard to improve data visualization and fix type issues:

  • Changed numeric types in API response to strings for better precision
  • Added peak RPS data to the rate graph for more comprehensive monitoring
  • Implemented a "maxLine" feature to replace the previous maxLimit approach for clearer rate limit visualization
  • Added support for both stacked and individual chart variants
  • Fixed date formatting by properly handling UTC timezone with 'Z' suffix
  • Updated cache key to "rpc-usage-last-24-hours:v2" to ensure fresh data after changes
  • Removed unnecessary CardFooter component and simplified chart rendering logic
  • Enhanced tooltip display for better readability

These changes provide users with more accurate and detailed information about their RPC usage patterns.

PR-Codex overview

This PR focuses on changing data types from number to string for various properties in the usage API and charts, ensuring consistency in data handling. It also simplifies chart components and updates how data is formatted and displayed.

Detailed summary

  • Changed peakRPS and averageRate types from number to string in several files.
  • Updated the CountGraph and RateGraph components to handle new data types.
  • Modified date formatting in components to include a "Z" suffix.
  • Simplified chart rendering logic in ThirdwebAreaChart.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:02am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 18, 2025 9:02am
login ⬜️ Skipped (Inspect) Apr 18, 2025 9:02am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 18, 2025 9:02am
wallet-ui ⬜️ Skipped (Inspect) Apr 18, 2025 9:02am

@vercel vercel bot temporarily deployed to Preview – login April 18, 2025 08:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 18, 2025 08:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 18, 2025 08:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 18, 2025 08:42 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5b35a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jnsdls jnsdls marked this pull request as ready for review April 18, 2025 08:42
@jnsdls jnsdls requested review from a team as code owners April 18, 2025 08:42
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Apr 18, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 18, 2025
@codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.17%. Comparing base (03e2385) to head (5b35a62).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6766   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files         896      896           
  Lines       56903    56903           
  Branches     3940     3940           
=======================================
  Hits        31396    31396           
  Misses      25411    25411           
  Partials       96       96
Flag Coverage Δ
packages 55.17% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.75 KB (0%) 1.1 s (0%) 217 ms (+120% 🔺) 1.3 s
thirdweb (cjs) 139.02 KB (0%) 2.8 s (0%) 449 ms (+78.83% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 59 ms (+381.88% 🔺) 171 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 41 ms (+1413.11% 🔺) 51 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 127 ms (+601.72% 🔺) 514 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 18, 2025 •
edited
Loading

Merge activity

@jnsdls
Update RPC usage charts to handle string values and improve visualiza…
5b35a62 
…tion (#6766)

# Update RPC Usage Dashboard with Enhanced Visualization

This PR updates the RPC usage dashboard to improve data visualization and fix type issues:

- Changed numeric types in API response to strings for better precision
- Added peak RPS data to the rate graph for more comprehensive monitoring
- Implemented a "maxLine" feature to replace the previous maxLimit approach for clearer rate limit visualization
- Added support for both stacked and individual chart variants
- Fixed date formatting by properly handling UTC timezone with 'Z' suffix
- Updated cache key to "rpc-usage-last-24-hours:v2" to ensure fresh data after changes
- Removed unnecessary CardFooter component and simplified chart rendering logic
- Enhanced tooltip display for better readability

These changes provide users with more accurate and detailed information about their RPC usage patterns.
@graphite-app graphite-app bot force-pushed the Update_RPC_usage_charts_to_handle_string_values_and_improve_visualization branch from f1adae1 to 5b35a62 Compare April 18, 2025 08:55
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 18, 2025 08:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 18, 2025 08:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 18, 2025 08:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 18, 2025 08:55 Inactive
@graphite-app graphite-app bot merged commit 5b35a62 into main Apr 18, 2025
23 checks passed
@graphite-app graphite-app bot deleted the Update_RPC_usage_charts_to_handle_string_values_and_improve_visualization branch April 18, 2025 09:02
@vercel vercel bot temporarily deployed to Production – docs-v2 April 18, 2025 09:02 Inactive
@vercel vercel bot temporarily deployed to Production – login April 18, 2025 09:02 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 18, 2025 09:02 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 18, 2025 09:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@jnsdls jnsdls

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @joaquim-verges